Try to add danger comments
What does this MR do and why?
Check on CI if the MR removed any file that was in a .rubocop_todo
. Also, add a bin/rubocop-outdated-todo --fix
to help contributors to remove deleted files from rubocop todos.
TODO
-
Add the bin/rubocop-outdated-todo
on a CI stage -
Create bin/rubocop-outdated-todo --fix
Screenshots or screen recordings
- Example of
bin/rubocop-outdated-todo-check
output (from a test job):
$ bin/rubocop-outdated-todo
'.rubocop_todo/api/ensure_string_detail.yml' contains the following removed files:
- 'ee/lib/api/analytics/group_activity_analytics.rb'
It looks like you remove files and did not remove their related rubocop todos.
>> Try running `bin/rubocop-outdated-todo --fix` to fix that
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Kassio Borges