Skip to content

Refactor CiIcon component (and remove CiBadgeLink)

Sascha Eggenberger requested to merge refactor-ci-icons into master

What does this MR do and why?

Refactors CiIcon. This MR combines the features of CiIcon & CiBadgeLink to make it easier to use the component. It also simplifies the use of CiIcon as it reduces the sizes to a single one (md).

Features:

  • Adds GlBadge from CiBadgeLink
  • Migrates all instances of CiBadgeLink to CiIcon
  • Removes size options as all instances use the same size now
  • Removes unused props from CiIcon: isActive, isInteractive & cssClasses

Screenshots or screen recordings

Before After
http://gdk.test:3000/top-group/top-project/-/artifacts image image
http://gdk.test:3000/top-group/top-project/-/pipelines/604 image image
http://gdk.test:3000/top-group/top-project/-/jobs/6874 image image
http://gdk.test:3000/top-group/top-project/-/jobs/6874 image image
http://gdk.test:3000/top-group/top-project/-/jobs/6874 image image
http://gdk.test:3000/top-group/top-project/-/jobs image image

How to set up and validate locally

Some Test pages:

  1. http://gdk.test:3000/flightjs/Flight
  2. http://gdk.test:3000/flightjs/Flight/-/merge_requests
  3. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3
  4. http://gdk.test:3000/flightjs/Flight/-/tree/master
  5. http://gdk.test:3000/flightjs/Flight/-/commit/dc82ccd232ea5df10e44459b3975c244321b4339
  6. http://gdk.test:3000/flightjs/Flight/-/branches
  7. http://gdk.test:3000/flightjs/Flight/-/commits/master?ref_type=heads
  8. http://gdk.test:3000/flightjs/Flight/-/tags
  9. http://gdk.test:3000/flightjs/Flight/-/pipelines
  10. http://gdk.test:3000/flightjs/Flight/-/pipelines/9
  11. http://gdk.test:3000/flightjs/Flight/-/jobs
  12. http://gdk.test:3000/flightjs/Flight/-/jobs/137
  13. http://gdk.test:3000/flightjs/Flight/-/ci/editor?branch_name=master
  14. http://gdk.test:3000/flightjs/Flight/-/artifacts
  15. http://gdk.test:3000/flightjs/Flight/-/issues/9

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to UX Paper Cuts 16.5 → Cleanup (#424403 - closed)

Edited by Miguel Rincon

Merge request reports