Refactor CiIcon component (and remove CiBadgeLink)
What does this MR do and why?
Refactors CiIcon
. This MR combines the features of CiIcon
& CiBadgeLink
to make it easier to use the component. It also simplifies the use of CiIcon
as it reduces the sizes
to a single one (md
).
Features:
- Adds
GlBadge
fromCiBadgeLink
- Migrates all instances of
CiBadgeLink
toCiIcon
- Removes size options as all instances use the same size now
- Removes unused props from
CiIcon
:isActive
,isInteractive
&cssClasses
Screenshots or screen recordings
How to set up and validate locally
Some Test pages:
- http://gdk.test:3000/flightjs/Flight
- http://gdk.test:3000/flightjs/Flight/-/merge_requests
- http://gdk.test:3000/flightjs/Flight/-/merge_requests/3
- http://gdk.test:3000/flightjs/Flight/-/tree/master
- http://gdk.test:3000/flightjs/Flight/-/commit/dc82ccd232ea5df10e44459b3975c244321b4339
- http://gdk.test:3000/flightjs/Flight/-/branches
- http://gdk.test:3000/flightjs/Flight/-/commits/master?ref_type=heads
- http://gdk.test:3000/flightjs/Flight/-/tags
- http://gdk.test:3000/flightjs/Flight/-/pipelines
- http://gdk.test:3000/flightjs/Flight/-/pipelines/9
- http://gdk.test:3000/flightjs/Flight/-/jobs
- http://gdk.test:3000/flightjs/Flight/-/jobs/137
- http://gdk.test:3000/flightjs/Flight/-/ci/editor?branch_name=master
- http://gdk.test:3000/flightjs/Flight/-/artifacts
- http://gdk.test:3000/flightjs/Flight/-/issues/9
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Miguel Rincon