Migrate widget action buttons to GlDisclosureDropdown
What does this MR do and why?
Implements Migrate "app/assets/javascripts/vue_merge_reque... (#413499 - closed).
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Open any merge request
- Ensure you have a 'Status checks' widget
- Apply this patch:
show_dropdown.patch
Index: ee/app/assets/javascripts/vue_merge_request_widget/extensions/status_checks/index.vue
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/ee/app/assets/javascripts/vue_merge_request_widget/extensions/status_checks/index.vue b/ee/app/assets/javascripts/vue_merge_request_widget/extensions/status_checks/index.vue
--- a/ee/app/assets/javascripts/vue_merge_request_widget/extensions/status_checks/index.vue (revision 72a20345cd8fa948cc021428201f5e06cb5f438e)
+++ b/ee/app/assets/javascripts/vue_merge_request_widget/extensions/status_checks/index.vue (date 1696494668239)
@@ -87,7 +87,7 @@
tertiaryButtons() {
const actionButtons = [];
- if (this.hasError) {
+ if (!this.hasError) {
const isLoading = Boolean(this.loadingState);
actionButtons.push({
- Shrink your viewport to 700px wide
- Click on the three dots button in the Status checks widget