Skip to content

Fix draft comment files not loading

Stanislav Lashmanov requested to merge slashmanov/fix-draft-comment-files-not-loading into master

What does this MR do and why?

Fixes MR pending comments doesn't always load the rev... (#424086 - closed) by fetching the diff file when clicking on the Pending comments dropdown items.

Screenshots or screen recordings

Before After
Screen_Recording_2023-10-04_at_17.35.55 Screen_Recording_2023-10-04_at_17.34.41

How to set up and validate locally

  1. Create an MR with at least 3 files changed
  2. Open that MR on the Changes tab
  3. Leave a draft comment in each of the files (Click on Start a review button)
  4. Switch to a single file view mode (Show one file at a time checkbox)
  5. Go to the third file
  6. Refresh the page
  7. Click on the Pending comments button
  8. Click on the comment that was left on the first file
  9. The spinner should be visible and the file should load correctly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports