Skip to content

Check `observability_tracing` feature flag against root namespace

Mat Appelman requested to merge mappelman/apply-ff-at-root-namespace into master

What does this MR do and why?

observability_tracing Feature flag is used to gate an Experimental feature set.

We'd like to check if this feature flag has been enabled on a root group so all projects within that root group are enabled/disabled. This allows us to selectively enable the feature for specific user/customer namespaces on .com as part of our rollout.

This MR updates check to operate against root_namespace and also against project for backwards compatibility.

Closes gitlab-org/opstrace/opstrace#2412 (closed)

Signed-off-by: Mat Appelman mappelman@gitlab.com

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. In rails console enable the experiment on a root group: 
    Feature.enable(:observability_tracing, <root_group_id>)
  2. Visit any project tracing page such as http://127.0.0.1:3000/groups/flightjs/-/tracing
  3. Verify the page isn't a 404

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mat Appelman

Merge request reports