Skip to content

Add GitHub identifiers to all exceptions from import classes

Luke Duncalfe requested to merge ld-github-import-attach-GH-identifiers-to-all-errors into master

What does this MR do and why?

Previously, exceptions handled by rescuing from StandardError when importing GitHub objects did not result in us logging errors with any "GitHub identifiers". These identifiers are the data returned in the #github_identifiers methods in the Gitlab::GithubImport::Representation classes and are useful to understand what GitHub object was being imported.

This change will result in more GitHub identifiers being logged when unexpected things happen, and let us correlate failures with data in GitHub. For example, we see these errors on prod the past week, but can't correlate them with what GitHub object was being imported.

This should help debug errors during the Import and Integration team's large-scale importer tests including the errors related to #416486 (closed).

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Luke Duncalfe

Merge request reports