Skip to content

Enable observability auth scopes when tracing feature flags are enabled

Mat Appelman requested to merge mappelman/enable-observability-scopes-on-tracing-and-error-tracking into master

What does this MR do and why?

The only remaining item behind the feature flag observability_group_tab is the addition of auth scopes:

  • read_observability
  • write_observability

This MR removes the observability_group_tab feature flag all together and instead enables the above auth scopes only if the observability_tracing feature flag is enabled on the root_namespace. observability_tracing gates an Experimental feature that is only enabled on internal root namespaces for now, so there is no breaking change by removing observability_group_tab and replacing with a check against observability_tracing.

The tracing feature relies on these auth scopes and in future, metrics and logs features will also rely on them so those future feature flags can be added to this check.

Closes gitlab-org/opstrace/opstrace#2172 (closed)

Closes gitlab-org/opstrace/opstrace#2348 (closed)

Takes care of comments related to observability_group_tab feature flag in gitlab-org/quality/triage-reports#12260 (comment 1421509208)

How to set up and validate locally

  1. In rails console enable the experiment fully 
    Feature.enable(:observability_tracing, <root_group_id>)
  2. Visit any group within the <root_group_id> from step 1 and navigate to the access token page, e.g.: http://127.0.0.1:3000/groups/flightjs/-/settings/access_tokens
  3. Click Add new token
  4. Verify that read_observability and write_observability are available in the Select scopes section.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mat Appelman

Merge request reports