Skip to content
Snippets Groups Projects

Add support for group mention events to Discord integration

All threads resolved!

What does this MR do and why?

Add support for group mention events to Discord integration

Screenshots or screen recordings

Message in Discord

image

Settings

The settings currently suffer from a bug that causes them to be shown without any text.
However, this is currently also the case for IntegrationSlack in production.

I mentioned that bug (#417751 (comment 1588470357)) and hope to get some assistance to fix it.

image

How to set up and validate locally

  1. Setup a Discord webhook
  2. Enable the Discord integration in a group and select the two checkboxes for group mentions (the ones that currently have no text)
  3. Mention the group in an issue
  4. Observe the notification sent to Discord

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • James Nutt requested review from @jnutt and removed review request for @bmarjanovic

    requested review from @jnutt and removed review request for @bmarjanovic

  • Niklas van Schrick added 251 commits

    added 251 commits

    • ba40db80...81fa88be - 250 commits from branch gitlab-org:master
    • 348e68c5 - Merge branch 'master' into 'discord-support-group-mention-events'

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • James Nutt
  • Thanks @Taucher2003!

    One final question: since the group mention support was originally extracted from the Slack notification, should we be testing that class with the new shared examples?

    Otherwise, LGTM. :slight_smile:

  • added 1 commit

    • 26d503b1 - Fix bugs and add slack to tested integrations

    Compare with previous version

  • James Nutt requested review from @minac

    requested review from @minac

  • Mehmet Emin INAC resolved all threads

    resolved all threads

  • Mehmet Emin INAC approved this merge request

    approved this merge request

  • Thanks @Taucher2003! Setting the MWPS.

  • Mehmet Emin INAC enabled an automatic merge when the pipeline for 3ddff161 succeeds

    enabled an automatic merge when the pipeline for 3ddff161 succeeds

  • @Taucher2003, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Mehmet Emin INAC mentioned in commit c1d2c37a

    mentioned in commit c1d2c37a

  • added workflowstaging label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 changed milestone to %16.5

    changed milestone to %16.5

  • Please register or sign in to reply
    Loading