Add support for group mention events to Discord integration
What does this MR do and why?
Add support for group mention events to Discord integration
Screenshots or screen recordings
Message in Discord
Settings
The settings currently suffer from a bug that causes them to be shown without any text.
However, this is currently also the case for IntegrationSlack in production.
I mentioned that bug (#417751 (comment 1588470357)) and hope to get some assistance to fix it.
How to set up and validate locally
- Setup a Discord webhook
- Enable the Discord integration in a group and select the two checkboxes for group mentions (the ones that currently have no text)
- Mention the group in an issue
- Observe the notification sent to Discord
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @Taucher2003
added Leading Organization label
Hey @Taucher2003!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
This merge request will be counted as part of the running Hackathon!
Check out the Hackathon page for more information!
This message was generated automatically. You're welcome to improve it.
added Hackathon label
added linked-issue label
mentioned in issue Taucher2003/reporting#177 (closed)
- A deleted user
added backend featureaddition typefeature labels
1 Warning This merge request does not refer to an existing milestone. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/integrations.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend lma-git
(UTC-7)
minac
(UTC+3)
groupimport and integrate (backend) jnutt
(UTC+1)
Maintainer review is optional for groupimport and integrate (backend) Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 26d503b1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Create | 32 | 0 | 5 | 0 | 37 | ✅ | | Manage | 13 | 0 | 1 | 0 | 14 | ✅ | | Govern | 33 | 0 | 0 | 0 | 33 | ✅ | | Data Stores | 18 | 0 | 2 | 0 | 20 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 155 | 0 | 8 | 0 | 163 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
I do know that the UI has a bug, but as that bug is also present in master and production for other integrations, I'm going to mark this MR as ready anyways.
That way we can decide if we fix the bug within this MR or if we merge this without fixing the bug and fixing the bug in a follow up.
added workflowready for review label and removed workflowin dev label
@pslaughter
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
requested review from @pslaughter
added IntegrationDiscord label
mentioned in issue gitlab-org/quality/triage-reports#14359 (closed)
added 1 commit
- ead86919 - Add docs for group mention event support in Discord integration
- A deleted user
added documentation label
mentioned in issue gitlab-org/quality/triage-reports#14361 (closed)
Thanks for working on this @Taucher2003! @jnutt could you please review this IntegrationDiscord Community contribution? Thanks!
requested review from @jnutt and removed review request for @pslaughter
mentioned in issue gitlab-org/quality/triage-reports#14362 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14431 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14439 (closed)
- Resolved by Mehmet Emin INAC
Thank you so much for your recent hard work on the Discord integration, @Taucher2003!
This works well for me. I've looked at the linked bug, and I agree. I don't think the fix for the UI issue would require any further change to this MR.
@bmarjanovic, could you please do the maintainer review?
- Resolved by Mehmet Emin INAC
@jnutt
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @bmarjanovic and removed review request for @jnutt
added groupimport and integrate label
added devopsmanage sectiondev labels
added 993 commits
-
ead86919...d156cb27 - 992 commits from branch
gitlab-org:master
- ba40db80 - Merge branch 'master' into 'discord-support-group-mention-events'
-
ead86919...d156cb27 - 992 commits from branch
@Taucher2003 Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#quality
Slack channel.- Resolved by James Nutt
requested review from @jnutt and removed review request for @bmarjanovic
added 251 commits
-
ba40db80...81fa88be - 250 commits from branch
gitlab-org:master
- 348e68c5 - Merge branch 'master' into 'discord-support-group-mention-events'
-
ba40db80...81fa88be - 250 commits from branch
- Resolved by Mehmet Emin INAC
Thanks @Taucher2003!
One final question: since the group mention support was originally extracted from the Slack notification, should we be testing that class with the new shared examples?
Otherwise, LGTM.
added 1 commit
- 26d503b1 - Fix bugs and add slack to tested integrations
requested review from @minac
Thanks @Taucher2003! Setting the MWPS.
enabled an automatic merge when the pipeline for 3ddff161 succeeds
@Taucher2003, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit c1d2c37a
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
changed milestone to %16.5
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2517 (merged)