Skip to content

Update the visualization designer's visualize column

What does this MR do and why?

This MR updates the visualization designer's type selector to match the proposed changes in Update the visualization designer's visualize c... (#426565 - closed).

The following changes are made:

  • Move the type selector into a form group and remove the empty column.
  • Update the type selector to always be a dropdown and remove buttons.
  • Rename the type component from *Inspector to *TypeSelector.
  • Add inline validation to the visualization designer's type selector.
  • Updated the designer to validate all inputs at once when saving.
  • Changed the visualization type names to sentence case.
  • Updated the dropdown to display the type name instead of the value.
  • Update specs.

Note that groupproduct analytics is an experimental feature that is hidden behind a default off feature flag.

Screenshots or screen recordings

Validation recording

Screen_Recording_2023-10-04_at_10.41.34

Layout

Before After
image image

Selected a metric but no type yet

Before After
image image

How to set up and validate locally

  1. Follow these instructions to setup Product Analytics in GDK.
    • Be sure to also enable the designer's feature flag combined_analytics_visualization_editor.
  2. Onboard Product Analytics by setting up the feature at Project > Analytics > Analytics dashboards.
  3. Navigate back to Project > Analytics > Analytics dashboards and click on Visualizaiton Designer at the top right.
  4. Use the designer to create a visualization and explore the validation behaviour.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #426565 (closed)

Edited by Jiaan Louw

Merge request reports