Add setting for external redirect page for job artifacts
What does this MR do and why?
Add setting for external redirect page for job artifacts
Create a new migration in application_settings and add setting to API and helper
Modify controller to skip linking to external redirect page if setting is disabled (and add corresponding test)
Add administration documentation for the new setting
Changelog: changed
Fixes #384228 (closed)
Screenshots or screen recordings
With setting enabled (default):
How to set up and validate locally
- Enable GitLab Pages in GDK
- Create a new project, import from Pages plain HTML
- Run pipeline
- Browse job artifacts
- Clicking index.html should open external redirect page (current behavior)
- Open admin area
- Settings
- CI/CD
- Expand Continuous Integration and Deployment
- Scroll to bottom of section
- Uncheck "Enable the external redirect warning page for job artifacts"
- Save changes
- Reload job artifacts browse page
- Clicking index.html should now go straight to index.html without redirect page
MR acceptance checklist
-
I have evaluated the MR acceptance checklist for this MR.
Related to #384228 (closed)
Edited by ftab