Skip to content

Use 1-based numbering for log lines

Miguel Rincon requested to merge 324146-use-1-based-number-for-log-lines into master

What does this MR do and why?

While working on !132964 (merged) I found we could simplify some of the code that processes logs.

Changes the log format used in the frontend to use 1-based number of the lines as that's how they are displayed to the user.

I simplifies line display and bookmarking in the log.

Screenshots or screen recordings

No changes are expected from this change, but we can check the line numbers are not affected:

image

How to set up and validate locally

  1. Visit a job log page (e.g. http://gdk.test:3000/group1/project1/-/jobs/**
  2. Check log lines numbers are sequential as before

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #324146 (closed)

Edited by Miguel Rincon

Merge request reports