Skip to content

Add label to merged results pipelines

Manuel Grabowski requested to merge mg-add-merged-results-label-20230929 into master

What does this MR do and why?

This MR adds a label to merged results-type merge request pipelines. Normal merge request pipelines as well as merge train pipelines are already labeled, and it can be tricky to figure out why a merge request pipeline exist without being labelled if you don't already know what to look for (i.e. merged results pipelines). We recently made this a bit more clear in the docs, but ideally we should just label merged results pipelines as well.

I believe this would implement Frontend: Introduce new pipeline label for Unla... (#353090 - closed), however I'm not quite sure if I grasped this issue entirely. We say that it's blocked by Backend: Make it easier to understand and diffe... (#217718 - closed) – but I didn't need to do anything to get this to work. It's very possible that I vastly underestimated the complexity of this and forgot to account for edge cases in some way, but it worked just as I'd expect it to in my local testing.

I'm wondering if Backend: Make it easier to understand and diffe... (#217718 - closed) is mostly about internal cleanup – it is a bit odd that we expose merged_result_pipeline? as merge_request_pipeline in the flags… so maybe the remaining goal of Backend: Make it easier to understand and diffe... (#217718 - closed) would just be to rename this? But other than that it seems to me that most of the proposal in that issue is already done. If it is just that I don't think it should be blocking this change, as that could also be done afterwards – this change only uses what's there already, it doesn't add or complicate anything in the backend.

Screenshots or screen recordings

Pipeline 583 was created after disabling merged results pipelines in the settings, to make sure normal MR pipelines aren't affected in an unintended way.

Before After
image image
image image

Hover text:

image

How to set up and validate locally

  1. Set up new project
  2. Enable Merged Results pipelines in Merge Request settings
  3. Add basic CI/CD config for merge request pipelines
  4. Create MR
  5. Observe label on pipeline

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Manuel Grabowski

Merge request reports