Skip to content

Inherit from BaseResolver in specs

Heinrich Lee Yu requested to merge 363131-fix-test-resolvers into master

What does this MR do and why?

Inherit from BaseResolver in specs

When creating resolver classes for use in specs, we should still inherit from BaseResolver since initializing a field now calls some methods on the resolver

When upgrading to GraphQL 2.x, this results in spec failures like: https://gitlab.com/gitlab-org/gitlab/-/jobs/5131348861.

This is extracted from !88733 (merged) to make it easier to review

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #363131 (closed)

Edited by Heinrich Lee Yu

Merge request reports