Use log line js-* classes in js logic
What does this MR do and why?
Remove js-* class used for testing in logs
Previously log lines CSS classes were to used to both add style and logic to the log line. This change leave only js-*
classes in JS logic and tests.
-
js-log-line
: Represents log lines in the log that can be bookmarked and scrolled. There are two variants:~/ci/job_details/components/log/line.vue
~/ci/job_details/components/log/line_header.vue
-
log-line
: Represents logs line styles (padding & min-height). -
collapsible-line
: Hoverable log line styles
I think more work can be done to reduce the amount of HTML rendered, but at least this change creates a separation of concerns for these classes.
Screenshots or screen recordings
How to set up and validate locally
- Visit any project with a pipeline
- Run a pipeline (to create a job)
- Confirm the job log is display correctly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Miguel Rincon