Skip to content

Allow merges in the absence of a pipeline

Hordur Freyr Yngvason requested to merge allow-merge-when-no-pipeline into master

What does this MR do and why?

Prior to this change, MRs without pipelines could not be merged in projects with "Pipelines must succeed" enabled. But this was unexpected. For example:

  • Projects without a .gitlab-ci.yml could get blocked because of a group-level setting.
  • Users of rules who intentionally filtered out jobs for a given change needed to have a "dummy" job just to merge in such cases.

See #334281

Changelog: changed

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-09-27_at_11.29.46_AM Screenshot_2023-09-27_at_11.30.30_AM

How to set up and validate locally

  1. Enable Pipelines must succeed in a project without a .gitlab-ci.yml
  2. Create a merge request
  3. The Merge button should be visible

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Hordur Freyr Yngvason

Merge request reports