Use factories in other specs

What does this MR do and why?

Related to #425190 (closed)

Two factories zoekt_shard and zoekt_indexed_namespace were added in !130210 (merged). This MR uses those factories in all other specs where .create! was being used.

Screenshots or screen recordings

specs only

How to set up and validate locally

specs only

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.