Revert "Update dependency puma to '~> 6.4'"
What does this MR do and why?
What
This reverts commit 388913eb. Revert "Update dependency puma to '~> 6.4'"
Why
We started seeing 500 errors when we don't have a URL encoding query string:
$ curl -I 'http://gdk.test:3000/-/merge_requests?sort=created_date&state=<th:t=\"%24{dfb}%23foreach'
HTTP/1.1 400 Bad Request
Date: Mon, 25 Sep 2023 14:41:36 GMT
Reference: gitlab-com/gl-infra/production#16417 (comment 1577467984)
How to set up and validate locally
master
branch:
$ curl -I 'http://gdk.test:3000/-/merge_requests?sort=created_date&state=<th:t=\"%24{dfb}%23foreach'
HTTP/1.1 500 Internal Server Error
Content-Length: 244
Date: Mon, 25 Sep 2023 14:50:50 GMT
This branch:
$ curl -I 'http://gdk.test:3000/-/merge_requests?sort=created_date&state=<th:t=\"%24{dfb}%23foreach'
HTTP/1.1 400 Bad Request
Date: Mon, 25 Sep 2023 14:41:36 GMT
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Steve Xuereb