You need to sign in or sign up before continuing.
InternalEvents.track_event should be called with objects and not ids
What does this MR do and why?
Events sent from the frontend to the /api/v4/usage_data/track_event
endpoint did not get tracked in RedisHLL and therefor not in Service Ping.
See #424389 (closed) for context.
We are currently getting a lot of errors in Sentry due to this https://sentry.gitlab.net/gitlab/gitlabcom/?query=is%3Aunresolved+should+be+triggered+with+a+named+parameter
In this MR we start sending objects to InternalEvents.track_event
instead of ids
.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- Check out `master``
- Start
gdk redis-cli
and reset the most recent weekly Redis hll key for thei_analytics_dev_ops_adoption
eventDEL "{hll_counters}_i_analytics_dev_ops_adoption-2023-38"
- Go to http://gdk.test:3000/admin/dev_ops_reports and open the dev tools
- Click the "Dev" tab
- See that
track_event
fails - Check that
PFCOUNT "{hll_counters}_i_analytics_dev_ops_adoption-2023-38"
returns0
in the Redis CLI. - Switch to this branch
- Click the "Overview" tab and back to the "Dev" tab.
- Verify that
track_event
succeeds. - Check that
PFCOUNT "{hll_counters}_i_analytics_dev_ops_adoption-2023-38"
returns1
in the Redis CLI.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Jonas Larsen