Test: remove ambiguous data-testid on compare dropdowns
What does this MR do and why?
In !131849 (merged) I migrated data-qa-selectors
to data-testids
.
One of the changes accidentally added the same data-testid
to all dropdowns on the compare branch page. Which caused a failure in one of the E2E tests: #425732 (closed)
We actually discussed this in the MR, and now we know why it was like that: !131849 (comment 1564491460)
So this is essentially a partial revert of !131849 (merged) but changing the data-qa-selector
to data-testid
.
This only occurs on a certain flow of the E2E tests so it doesn't occur all the time, hence why it wasn't caught in the original MR.
How to set up and validate locally
Comment out: https://gitlab.com/gitlab-org/gitlab/-/blob/master/qa/qa/flow/merge_request.rb?ref_type=heads#L20-23
QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://192.168.4.31:3000 bundle exec rspec qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.