Skip to content

Add E2E test password approval when using SAML SSO

Mark Lapierre requested to merge ml-add-password-on-approval-with-saml-e2e-test into master

What does this MR do and why?

Adds a new E2E test of requiring a password to approve an MR when using SAML SSO.

Depends on:

Closes gitlab-org/quality/testcases#4135 (closed)

How to set up and validate locally

The test requires Group SAML, which requires HTTPS (via nginx or set ACCEPT_INSECURE_CERTS=true). Here's example GDK config:

https:
  enabled: true
port: 3443
nginx:
  enabled: true
  ssl:
    certificate: /Users/mark/gdks/main/gdk.test.pem
    key: /Users/mark/gdks/main/gdk.test-key.pem
omniauth:
  group_saml:
    enabled: true

To run the test, from the qa directory execute:

bundle install
export WEBDRIVER_HEADLESS=false # If you'd like to watch the test in action
export QA_GITLAB_URL="https://gdk.test:3443"
bundle exec rspec qa/specs/features/ee/browser_ui/10_govern/group/saml_sso_require_password_to_approve_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tiffany Rea

Merge request reports