Skip to content

Fix nav item hover menu button overlap

Scott de Jonge requested to merge super-sidebar-hover-menu-pin-button-fix into master

What does this MR do and why?

!130603 (merged) moved the pun/unpin buttons from within the <a> in <nav-item>. Previously a hasPill || isPinnable condition provided a space for the (optional) badge and pin/unpin button to render. Moving the button from within the link added absolute styles which made it overlap the text content.

This MR restores the hasPill || isPinnable condition to provide space in nav item for pin/unpin button in hover menus

Screenshots or screen recordings

Before After
CleanShot_2023-09-15_at_09.41.06_2x CleanShot_2023-09-15_at_09.48.05_2x

How to set up and validate locally

  1. View new navigation menu with long items e.g. "Secure" in Project
  2. Hover nav item to display hover menu
  3. Hover items in hover menu to check pin/unpin button renders correctly (does not overlap content)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports