Support commit_committer_check in API
What does this MR do?
This work resolves https://gitlab.com/gitlab-org/gitlab-ee/issues/9930 by adding support for the commit_committer_check rule in the project rules endpoint.
This is a minimal change, adding support in analogy to the other supported attributes, as requested by our users.
This is a simple boolean toggle on an underlying model, so there should be no technical risks. It uses the same permissions rules as the other rules in the API (only maintainers may edit), so does not introduce any additional operational risks. The worst case scenario is that the setting gets accidentally set which could block users from pushing changes. It is hard to imagine how that setting would be accidentally set in the API other than maliciously, and the risk is the same as if the web UI were to be used.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
This change is tested at the API request/response level. It does not require specific UI testing or any cross-browser testing.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Security
The check in question could be disruptive if set (it could prevent pushes). It needs to be restricted to authorised maintainers and admins only and needs to only be exposed to authorised users. The MR addresses these concerns.