Skip to content

Use new CubeJS "castNumerics" option

Elwyn Benson requested to merge 425118-use-new-cubejs-castnumeric-option into master

What does this MR do and why?

Use the new castNumerics option from CubeJS to ensure our number values are always correctly cast as JavaScript numbers (they are currently always returned as strings)

Note that product analytics is an experimental feature behind a default-off feature flag.

Screenshots or screen recordings

No visual differences.

data before data after
image image

How to set up and validate locally

  1. Be sure to run yarn when switching branch to have the correct @cubejs-client dependency installed
  2. Follow these instructions to setup Product Analytics in GDK.
  3. Onboard Product Analytics by setting up the feature at Project > Analytics > Analytics dashboards.
  4. Verify that dashboard values are returned as expected. Inspect network responses from CubeJS to verify values are numbers, not strings.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #425118 (closed)

Edited by Elwyn Benson

Merge request reports