Use more suitable completion prompt
What does this MR do and why?
This prompt is more likely to produce a valid response since it is more typical code.
Fixes #424293 (closed)
Test results
Run from my machine against gitlab.com
I cut most of the log messages so it just shows the test ran successfully
bundle exec bin/qa Test::Instance::All https://gitlab.com qa/specs/features/ee/api/14_model_ops/code_suggestions_spec.rb
==> Base URL: https://gitlab.com
ModelOps
Code Suggestions
on the GitLab API with PAT auth
returns a suggestion
Finished in 0.98961 seconds (files took 3.83 seconds to load)
1 example, 0 failures
Run from my machine against staging.gitlab.com
I cut most of the log messages so it just shows the test ran successfully
bundle exec bin/qa Test::Instance::All https://staging.gitlab.com qa/specs/features/ee/api/14_model_ops/code_suggestions_spec.rb
==> Base URL: https://staging.gitlab.com
ModelOps
Code Suggestions
on the GitLab API with PAT auth
returns a suggestion
Finished in 2.47 seconds (files took 2.64 seconds to load)
1 example, 0 failures
How to set up and validate locally
You can run the tests against staging.gitlab.com using the gitlab-qa
user as the tests do, or by using your own user. If you use gitlab-qa
you can skip below to running the tests, otherwise enable the Code Suggestions user preference (see https://docs.gitlab.com/ee/user/project/repository/code_suggestions.html#enable-code-suggestions-for-an-individual-user)
To run the tests, from the qa
directory:
export GITLAB_USERNAME=gitlab-qa # or your own username if you have Code Suggestions enabled in your preferences and via the feature flag
export GITLAB_QA_ACCESS_TOKEN=<from 1Password> # or your own access token
export GITLAB_QA_USER_AGENT=<from 1Password>
bundle install
bundle exec bin/qa Test::Instance::All https://staging.gitlab.com qa/specs/features/ee/api/14_model_ops/code_suggestions_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @mlapierre
- A deleted user
added QA label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA Andy Hohenner (
@AndyWH
) (UTC-7, 17 hours behind@mlapierre
)Dan Davison (
@ddavison
) (UTC-4, 14 hours behind@mlapierre
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@mlapierre - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ef96823aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 38 | 0 | 0 | 0 | 38 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | | Govern | 34 | 0 | 0 | 0 | 34 | ✅ | | Data Stores | 20 | 0 | 0 | 1 | 20 | ❗ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 163 | 0 | 1 | 1 | 164 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for ef96823aexpand test summary
+---------------------------------------------------------------+ | suites summary | +----------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------+--------+--------+---------+-------+-------+--------+ | ModelOps | 0 | 0 | 4 | 0 | 4 | ➖ | +----------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 4 | 0 | 4 | ➖ | +----------+--------+--------+---------+-------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
changed milestone to %16.4
added Quality maintenancepipelines typemaintenance labels
- Resolved by Andrejs Cunskis
@ddavison Could you please review this fix?
Straight to maintainer because it's a small change that doesn't change the actual code.requested review from @ddavison
mentioned in issue #408726 (closed)
mentioned in issue #424979 (closed)
enabled an automatic merge when the pipeline for 55a318f2 succeeds
mentioned in commit 2137bcc9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !136273 (merged)
mentioned in merge request !136644 (merged)
mentioned in merge request !138004 (merged)