Skip to content

Remove unused ruby_parser gem

Peter Leitzen requested to merge pl-remove-ruby-parser into master

What does this MR do and why?

This MR removes a gem 💎 ruby_parser and its transitive dependencies as it's no longer used since !115366 (merged).

Discovered while auditing it for Ruby 3.1/3.2 in #422680 (closed).

How to set up and validate locally

bundle rake gettext:regenerate
# Still works due to https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115366.

Validation:

  1. Roll back to parent of 9d3f4829
  2. Remove ruby_parser from Gemfile and bundle
  3. Running bundle rake gettext:regenerate will break
git reset --hard 9d3f48292bf5fe8a71303061a36f447418e41d66^
# Remove `ruby_parser` from `Gemfile`
bundle
bundle rake gettext:regenerate

rake aborted!
Gem::LoadError: ruby_parser is not part of the bundle. Add it to your Gemfile.
<internal:/home/peter/.dotfiles/asdf/installs/ruby/3.0.5/lib/ruby/site_ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/home/peter/.dotfiles/asdf/installs/ruby/3.0.5/lib/ruby/site_ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
/home/peter/devel/gitlab/gdk/gitlab/lib/tasks/gettext.rake:20:in `block (2 levels) in <main>'
/home/peter/.asdf/installs/ruby/3.0.5/bin/bundle:25:in `load'
/home/peter/.asdf/installs/ruby/3.0.5/bin/bundle:25:in `<main>'
Tasks: TOP => gettext:pot:create => /home/peter/devel/gitlab/gdk/gitlab/locale/gitlab.pot
(See full trace by running task with --trace)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports