[E2E] Mask secrets in kubernettes_cluster setup

What does this MR do and why?

For security purposes we should avoid logging test secret values and tokens during E2E test execution to avoid any potential for them to be leaked inadvertently.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

WORKSPACES_OAUTH_APP_ID=aaa WORKSPACES_OAUTH_APP_SECRET=bbb WORKSPACES_PROXY_DOMAIN=abc.def WORKSPACES_OAUTH_SIGNING_KEY=ccc WORKSPACES_DOMAIN_CERT=ddd workspaces_domain_key=eee WORKSPACES_WILDCARD_CERT=fff WORKSPACES_WILDCARD_KEY=ggg WORKSPACES_DOMAIN_KEY=hhh bundle exec rspec qa/specs/features/ee/browser_ui/3_create/remote_development/workspace_actions_spec.rb

Note when the test runs the helm repo add gitlab-workspaces-proxy .... command these variables should be masked in the console output.

     QA::Service::Shellout::CommandError:
       Command: `helm repo add gitlab-workspaces-proxy   https://gitlab.com/api/v4/projects/gitlab-org%2fremote-development%2fgitlab-workspaces-proxy/packages/helm/devel && helm repo update && helm upgrade --install gitlab-workspaces-proxy   gitlab-workspaces-proxy/gitlab-workspaces-proxy   --version 0.1.6   --namespace=gitlab-workspaces   --create-namespace   --set="auth.client_id=aaa"   --set="auth.client_secret=****"   --set="auth.host=http://gdk.test:3000"   --set="auth.redirect_uri=https://abc.def/auth/callback"   --set="auth.signing_key=****"   --set="ingress.host.workspaceDomain=abc.def"   --set="ingress.host.wildcardDomain=*.abc.def"   --set="ingress.tls.workspaceDomainCert=$(cat ddd)"   --set="ingress.tls.workspaceDomainKey=$(cat hhh)"   --set="ingress.tls.wildcardDomainCert=$(cat fff)"   --set="ingress.tls.wildcardDomainKey=$(cat ggg)"   --set="ingress.className=nginx" ` failed! ✘

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %16.4

added Quality maintenancerefactor typemaintenance labels

assigned to @john.mcdonnell

added QA label

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
QA	Jay McCure (@jay_mccure) (UTC+10, 9 hours ahead of @john.mcdonnell)	Dan Davison (@ddavison) (UTC-4, 5 hours behind @john.mcdonnell)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: ❗ test report for 191abe29

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Create           | 46     | 0      | 1       | 0     | 47    | ✅     |
| Data Stores      | 22     | 0      | 0       | 1     | 22    | ❗     |
| Govern           | 35     | 0      | 1       | 0     | 36    | ✅     |
| Verify           | 8      | 0      | 0       | 0     | 8     | ✅     |
| Manage           | 13     | 0      | 1       | 0     | 14    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 183    | 0      | 5       | 1     | 188   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: ❗ test report for 191abe29

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Data Stores      | 117    | 0      | 3       | 3     | 120   | ❗     |
| Plan             | 246    | 0      | 10      | 0     | 256   | ✅     |
| Verify           | 147    | 0      | 15      | 3     | 162   | ❗     |
| Create           | 559    | 0      | 89      | 4     | 648   | ❗     |
| Manage           | 158    | 0      | 13      | 3     | 171   | ❗     |
| Release          | 15     | 0      | 3       | 0     | 18    | ✅     |
| Govern           | 179    | 0      | 6       | 3     | 185   | ❗     |
| Package          | 226    | 0      | 17      | 12    | 243   | ❗     |
| Configure        | 1      | 0      | 9       | 0     | 10    | ✅     |
| Growth           | 0      | 0      | 6       | 0     | 6     | ➖     |
| Systems          | 7      | 0      | 0       | 0     | 7     | ✅     |
| GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
| Analytics        | 7      | 0      | 0       | 0     | 7     | ✅     |
| Fulfillment      | 8      | 0      | 69      | 0     | 77    | ✅     |
| Monitor          | 36     | 0      | 7       | 0     | 43    | ✅     |
| ModelOps         | 0      | 0      | 6       | 0     | 6     | ➖     |
| Secure           | 6      | 0      | 12      | 0     | 18    | ✅     |
| Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 1714   | 0      | 271     | 28    | 1985  | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

changed the description

changed the description

changed the description

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

LGTM 👍

approved this merge request

requested review from @treagitlab

merged

mentioned in commit aae50402

mentioned in issue gitlab-org/quality/pipeline-triage#216 (closed)

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

mentioned in issue gitlab-org/quality/pipeline-triage#217 (closed)

added releasedpublished label and removed releasedcandidate label

mentioned in issue gitlab-org/quality/pipeline-triage#227 (closed)

mentioned in issue gitlab-org/quality/pipeline-triage#228 (closed)