Skip to content

Draft: Add scenarios where direct maintainer review is acceptable

Vishal Tak requested to merge vtak/process_update_direct_maintainer_review into master

What does this MR do and why?

What

This MR adds scenarios where it is acceptable to ask for a maintainer review directly.

Scenario 1

Code Owners are the closest ones working on the codebase in that section of the code. Thus, they have the most context about the architecture, nuances, long-term flexibility and maintainability of the section of codebase for which they are Code Owners. In such cases, we should rely on their best judgement and allow for them to go to a maintainer review if they choose to.

Scenario 2

It is not uncommon in some teams to work on a MR while pair-programming with a Code Owner/Maintainer. In such a scenario, it should be acceptable to send the MR to a maintainer review directly for that specific category(e.g. frontend, backend).

Why

To increase efficiency and results and also make the review process lightweight where possible for the MR authors.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vishal Tak

Merge request reports