Skip to content

Move notes.scss to page_bundles from page_specific_bundles

What does this MR do and why?

Move notes.scss to page_bundles from page_specific_bundles. Behind FF page_specific_styles

Only enabled for gitlab_team_members on gitlab.com

Screenshot_2023-11-22_at_5.23.34_PM

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Area Before After
Issue notes Screenshot_2023-11-22_at_5.28.54_PM Screenshot_2023-11-22_at_5.47.38_PM
MR diffs notes Screenshot_2023-11-22_at_5.58.59_PM Screenshot_2023-11-22_at_5.58.59_PM
Work item notes Screenshot_2023-11-22_at_5.31.13_PM Screenshot_2023-11-22_at_5.47.04_PM
Epic notes Screenshot_2023-11-22_at_5.40.28_PM Screenshot_2023-11-22_at_5.52.24_PM
Snippets comments Screenshot_2023-11-22_at_5.43.33_PM Screenshot_2023-11-22_at_5.48.06_PM
Commit comments Screenshot_2023-11-22_at_5.45.16_PM Screenshot_2023-11-22_at_5.45.16_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. In rails console enable the FF
    Feature.enable(:page_specific_styles)
  2. Visit all the pages mentioned in the screenshots section
  3. See that there is no difference in the notes styling

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #239856 (closed)

Edited by Deepika Guliani

Merge request reports