Skip to content

Include has_merge_request to Vulnerability Read Model

Bala Kumar requested to merge 371313-backend-has-merge-request-model-addition into master

What does this MR do and why?

Vulnerabilities::Read model addition to support has_merge_request columns introduced via !127329 (merged)

This is MR-4 related to Backend: Add hasMergeRequest filter to Vulnerab... (#371313 - closed)

How to set up and validate locally

In rails console we should observe the validation errors and with_merge_request scope working fine like below.

> vulnerability_read =  Vulnerabilities::Read.last

> vulnerability_read.has_merge_request = nil

> vulnerability_read.valid?
=> false

> vulnerability_read.errors
=> #<ActiveModel::Errors [#<ActiveModel::Error attribute=has_merge_request, type=inclusion, options={:message=>"must be a boolean value", :value=>nil}>]>
> last_vulnerability_read = Vulnerabilities::Read.last
> temp = Vulnerabilities::Read.last
> temp.update(has_merge_request: true)
>  Vulnerabilities::Read.with_merge_request.pluck(:vulnerability_id).include?(temp.vulnerability_id)
=> true

# rollback the update in local
> temp.update(has_merge_request: last_vulnerability_read.has_merge_request)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #371313 (closed)

Edited by Bala Kumar

Merge request reports