Skip to content

Do not override ActiveRecord associations to mark and allow cross-joins

What does this MR do and why?

See description of #424307 (closed) for details.

We need to change 2 problematic instances of allowing cross-joins to the safer option, which is what this MR does.

Doing this leads to an N+1 check spec failing, and that spec has been skipped for now. A followup issue has been created to make sure it is worked on later.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #424307 (closed)

Edited by Manoj M J

Merge request reports

Loading