Skip to content

Update search query to hide archived from milestones results

Ravi Kumar requested to merge 421464-update-search-query-to-hide-archived into master

What does this MR do and why?

This MR is hiding the milestones from the archived projects in the group and global searches for basic and advanced searches. It is backed by the feature flag search_milestones_hide_archived_projects which can accept user as an actor. If the query param include_archived=true is passed then the results will contain the milestones from the archived projects as well.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

For basic search:

  • Disable the Advanced search
  • Create a milestone with some specific keyword like qwerty in a project A
  • Create a milestone with some specific keyword like qwerty in a project B
  • Now search for qwerty. You should see the results from both projects
  • Now archive either Project A or Project B
  • Now enable the feature-flag search_milestones_hide_archived_projects
Feature.enable :search_milestones_hide_archived_projects
  • Now search again, you should see the results from only non-archived project
  • Now pass include_archived=true in the query param
  • Now search for qwerty. You should see the results from both projects

For advanced search:

  • Enable the advanced search. Unarchive the archived project. And repeat the process. You can skip the steps to create the milestones because you already did before

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #421464 (closed)

#423861 (closed)

Edited by Ravi Kumar

Merge request reports