Skip to content

Project Approval Settings for scan result policy

Artur Fedorov requested to merge 418765-policies-merge-requests-settings into master

What does this MR do and why?

This MR adds new settings for any merge request rule

When any merge request rule is selected for scan result policy is selected

User can see new set of settings specific to any merge request rule

This MR resolves #418765 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Description UI
Project level project level settings.mov
Project level validation project validation.mov
Group level group level.mov

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable feature flag
Feature.enable(:scan_result_policy_settings)
  1. Go to project or group
  2. Secure -> Policies -> New policy -> new scan result policy
  3. See default settings on bottom
  4. Select any merge request rule -> check if settings are changed to any merge request specific settings
  5. New settings should be visible if at least one of selected rules is any merge request rule
  6. Switch to yaml mode, change settings by typing, switch back to rule mode
  7. Mess around in yaml mode with settings keys, enabled key name or boolean value, switch back to rule mode, make sure validation is working

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #418765 (closed)

Edited by Artur Fedorov

Merge request reports