Skip to content

Remove tooltip from "Apply" button for suggestions

Jessie Young requested to merge jy-tooltip-idea into master

What does this MR do and why?

  • The tooltip was information, used to let the user know that applying the suggestion would also resolve all related threads.
  • The tooltip sometimes made it so that the "Apply" button was not accessible.
  • Several people have experienced this issue as frustrating UX.
  • Rather than fixing the tooltip, this MR suggests moving this information into helper text and removing the tooltip altogether when the "Apply" button is enabled.
  • This MR keeps the tooltip in place then the "Apply" button is disabled.
  • Came up in Slack a a UX issue when the browser is a certain size

Screenshots or screen recordings

Before After
Screenshot_2023-09-01_at_12.06.22_PM Screenshot_2023-09-01_at_12.05.26_PM
Screenshot_2023-09-01_at_11.58.45_AM Screenshot_2023-09-05_at_3.01.26_PM

How to set up and validate locally

  • Create a merge request and suggest 1 or more changes
  • Click on the "Apply suggestions" dropdwn
  • The "Apply" button should not have a tooltip and the default commit message should indicate that applying the suggested changes will resolve the related threads.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jessie Young

Merge request reports