Skip to content

Resolve "Fix external user create dropdown empty state"

Thomas Hutterer requested to merge 420921-fix-external-user-create-dropdown-empty-state into master

What does this MR do and why?

An External user cannot create new things (projects, groups, issues), so for them, the "➕ Create new..." menu in the new sidebar was empty.

Now we check the menu items count and if it's 0, we don't render the dropdown. This is the same behavior as we have in our old navigation design.

Fixes #420921 (closed).

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

  • Edit any user in http://gdk.test:3000/admin/users/ and activate the "External" checkbox and save.
  • Impersonate this user (also from the admin area).
  • Check the left sidebar. There should be no "➕" dropdown in the top row.
  • Undo the External setting, impersonate again and verify that the dropdown now shows up again.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports