You need to sign in or sign up before continuing.
Update custom dashboard with MVC design
What does this MR do and why?
Update the custom dashboard component to match the designs from New Custom Dashboard Flow - Dashboard designer MVC (#422024 - closed).
Changes are largely visual in nature, but they include:
- Add a page title to edit mode.
- Add an empty state for new dashboards.
- Add no visualization validation to edit mode.
- Update the
Dashboard title
input to be smaller and add inline validation. - Update the new dashboard state to start without a title.
- Update the
Save
button to exit edit mode after successfully saving to match new dashboard flow. - Move
Save
&Cancel
edit buttons to bottom of view to match the designs. - Remove the
Go back
button on dashboards to match the designs. - Remove
Code
button & view from edit mode to match the designs. - Remove the edit mode dashboard grey background to match the designs.
- Remove the dashboard filters from the edit mode to match the desgins.
- Fix a bug where new dashboards saved in local cache could not be updated.
Note: Analytics dashboard is an experimental feature hidden behind a default off feature flag.
Note: There is a sepreate issue to update the visualizations sidebar New Custom Dashboard Flow - Available visualiza... (#422025 - closed).
Screenshots or screen recordings
Recording
Analytics-dashboards--Gitlab-Org-Snowplow2--GitLab
Dashboard view
Removed back button
New dashboard
Edit dashboard
Validation
Additional validate states added
How to set up and validate locally
- Follow these instructions to setup Product Analytics in GDK.
- Onboard
Product Analytics
by setting up the feature at Project > Analytics > Analytics dashboards. - Enable custom dashboards by following the alert prompt on Project > Analytics > Analytics dashboards.
- Create a new custom dashboard by clicking on
New dashboard
on Project > Analytics > Analytics dashboards. - Edit your newly created custom dashboard by clicking on
Edit
button, making some changes and clickingSave your dashboard
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #422024 (closed)
Edited by Jiaan Louw