Skip to content

Use Rails 7.1 default for AS::TimeWithZone.name

Malcolm Locke requested to merge fix-rails-time-with-zone-name-deprecation into master

What does this MR do and why?

Use Rails 7.1 default for ActiveSupport::TimeWithZone.name

This removes the following deprecation warning:

DEPRECATION WARNING: ActiveSupport::TimeWithZone.name has been deprecated and
from Rails 7.1 will use the default Ruby implementation.
You can set `config.active_support.remove_deprecated_time_with_zone_name = true`
to enable the new behavior now.
 (called from execute_all at /srv/gitlab/lib/gitlab/graphql/subscriptions/action_cable_with_load_balancing.rb:16)

image

This warning is being emitted by the graphql-ruby gem by the call to super here

graphql-ruby has already been updated to support both the deprecated behaviour and the Rails 7.1 default behaviour in https://github.com/rmosolgo/graphql-ruby/pull/3774 so we should be safe to update to the new default. The fix to graphql-ruby was applied in 1.13.3, we are currently using 1.13.12.

See https://log.gprd.gitlab.net/goto/bc4a52c0-a62d-11ed-9f43-e3784d7fe3ca for logs

Edited by Malcolm Locke

Merge request reports