Adds page URL params for dependency proxy pagination
What does this MR do and why?
- Adds vue-router to dependency proxy.
- On pagination change, push query params to URL.
- watch
$route
so that components are updated when URL is updated
Screenshots or screen recordings
Before | After |
---|---|
Pagination is not persisted in the URL | Screen_Recording_2023-08-24_at_12.09.42_pm |
How to set up and validate locally
Setup
- Enable dependency proxy on GDK.
- Visit Gitlab-org Group > Packages and registries > Dependency proxy
- Assuming
172.16.123.1:3000/gitlab-org/dependency_proxy/containers
is theDependency proxy image prefix
on the page, run the following on the terminal:versions=("latest" "1.33.1" "1.33" "1.32.1" "1.32" "1.31.1" "1.31" "1.30.1" "1.30" "1.29.3" "1.29.2" "1.29.1" "1.29" "1.28.4" "1.28.3" "1.28.2" "1.28.1" "1.28" "1.27.2" "1.27.1" "1.27" "1.26.2" "1.26.1" "1.26" "1.25.1"); proxy_url="172.16.123.1:3000/gitlab-org/dependency_proxy/containers"; for version in "${versions[@]}"; do docker pull "${proxy_url}/busybox:${version}"; done
- Refresh the page to see the images & pagination
Validation
- Pagination should work & url should be updated.
- Refreshing the page with pagination should show the same list
- Pagination using the browser back should render the paginated page.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #416932 (closed)
Edited by Rahul Chanila