Skip to content

Convert notification_settings.user_id to loose foreign key

Manoj M J requested to merge 421414-cells-iteration-2-convert-fk-between-users-notification_settings into master

What does this MR do and why?

notification_settings is a main_cell table now, and users is a main_clusterwide table.

Since these tables belong to 2 different databases now, any foreign keys that exists between these 2 tables should be converted to Loose foreign keys, which is what this MR does.

I've grepped the usage of notification_settings.user_id in the code, and there does not appear to be any cases where a notification_settings.user_id pointing to a non-existing user could cause trouble, so we are safe 👍

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #421414 (closed)

Edited by Manoj M J

Merge request reports