Skip to content

Confirm access level to fix protected tag specs

Nailia Iskhakova requested to merge 422727-fix-protected-tag-spec into master

What does this MR do and why?

Adding additional click in choose_access_level_role(role) method to "unfocus" from access level dropdown and confirm selection to fix QA failure in qa/specs/features/browser_ui/3_cr... (#422727 - closed) - qa/specs/features/browser_ui/3_create/repository/protected_tags_spec.rb

The code was recently changed in !126649 (merged) which affected all reliable suites. See #422727 (comment 1521522503)

Screenshots or screen recordings

Click to expand

Obscuring element issue before this change

Screenshot_2023-08-21_at_18.21.19

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Run the code from this branch against Staging Canary - ensure to pass QA_COOKIES='gitlab_canary=true' along with other required QA env vars
    bundle exec bin/qa Test::Instance::All https://staging.gitlab.com -- qa/specs/features/browser_ui/3_create/repository/protected_tags_spec.rb:33
[Aug 21 2023 18:35:50 CEST (QA Tests)] INFO  -- clicking :create_tag_button
[Aug 21 2023 18:35:51 CEST (QA Tests)] WARN  -- Potentially Slow Code 'click_element create_tag_button' took 1.174s
        cannot be created by an unauthorized developer_user

Top 1 slowest examples (49.21 seconds, 100.0% of total time):
  Create Repository tags when protected behaves like unsuccessful tag creation cannot be created by an unauthorized developer_user
    49.21 seconds ./qa/specs/features/browser_ui/3_create/repository/protected_tags_spec.rb:33

Finished in 49.22 seconds (files took 4.9 seconds to load)
1 example, 0 failures

Randomized with seed 27935

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #422727 (closed)

Merge request reports