Display a group by dropdown
What does this MR do and why?
This MR does two things:
- Introduce
:vulnerability_report_grouping
feature flag - Display a listbox on the project vulnerability report when the feature flag is enabled
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable
:vulnerability_report_grouping
feature flag:echo "Feature.enable(:vulnerability_report_grouping)" | rails c
- Fork https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline against the default branch
- Visit Secure > Vulnerability Report
- See the group by button
It currently does nothing other than setting the state. Upcoming work will introduce more functionality.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #420055 (closed)
Merge request reports
Activity
changed milestone to %16.4
assigned to @svedova
- A deleted user
added backend feature flag labels
- Resolved by Savas Vedova
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Gregory Havenga (
@ghavenga
) (UTC+2, same timezone as@svedova
)Marc Shaw (
@marc_shaw
) (UTC+2, same timezone as@svedova
)frontend Ammar Alakkad (
@aalakkad
) (UTC+3, 1 hour ahead of@svedova
)Frédéric Caplette (
@f_caplette
) (UTC-4, 6 hours behind@svedova
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@d22ca629
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 91643bf7 and bfbfd71b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.17 MB 4.17 MB - 0.0 % mainChunk 3.02 MB 3.02 MB - 0.0 %
Note: We do not have exact data for 91643bf7. So we have used data from: 99711d00.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ac077c84expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 20 | 0 | 0 | 0 | 20 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | | Create | 38 | 0 | 0 | 2 | 38 | ❗ | | Govern | 36 | 0 | 0 | 0 | 36 | ✅ | | Plan | 47 | 0 | 0 | 0 | 47 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 161 | 0 | 1 | 2 | 162 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for bfbfd71bexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 112 | 0 | 0 | 4 | 112 | ❗ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 112 | 0 | 0 | 4 | 112 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for ac077c84expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 35 | 0 | 0 | 0 | 35 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 53 | 0 | 4 | 0 | 57 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@8080df94
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@3d9c0851
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c4fdb1ac
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7b4daa34
added 835 commits
-
1fe16a09...d0c8480d - 834 commits from branch
master
- ce6dd2ce - Display a group by dropdown
-
1fe16a09...d0c8480d - 834 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@fecea7c4
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bb47af2b
added 15 commits
-
c64c8a2c...05599c4b - 14 commits from branch
master
- 8faa9ae2 - Display a group by dropdown
-
c64c8a2c...05599c4b - 14 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c001de18
added 209 commits
-
8faa9ae2...305827ad - 208 commits from branch
master
- cd41b010 - Display a group by dropdown
-
8faa9ae2...305827ad - 208 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7747e721
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by Becka Lippert
@lorenzvanherwaarden can you please review this MR?
requested review from @lorenzvanherwaarden
@beckalippert can you please do a UX review for this? To simplify your life I created a video which shows the responsiveness. Currently this button does nothing. I'll add the functionality in a separate MR.
requested review from @beckalippert
mentioned in issue #420055 (closed)
removed backend label
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
@beckalippert
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- A deleted user
added backend label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@a58ab7f6