Skip to content
Snippets Groups Projects

Display a group by dropdown

Merged Savas Vedova requested to merge 420055-create-group-by-button into master

What does this MR do and why?

This MR does two things:

  • Introduce :vulnerability_report_grouping feature flag
  • Display a listbox on the project vulnerability report when the feature flag is enabled

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Enable :vulnerability_report_grouping feature flag: echo "Feature.enable(:vulnerability_report_grouping)" | rails c
  2. Fork https://gitlab.com/gitlab-examples/security/security-reports
  3. Run a pipeline against the default branch
  4. Visit Secure > Vulnerability Report
  5. See the group by button

It currently does nothing other than setting the state. Upcoming work will introduce more functionality.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #420055 (closed)

Edited by Savas Vedova

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    1 Warning
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Gregory Havenga current availability (@ghavenga) (UTC+2, same timezone as @svedova) Marc Shaw current availability (@marc_shaw) (UTC+2, same timezone as @svedova)
    frontend Ammar Alakkad current availability (@aalakkad) (UTC+3, 1 hour ahead of @svedova) Frédéric Caplette current availability (@f_caplette) (UTC-4, 6 hours behind @svedova)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 91643bf7 and bfbfd71b

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.17 MB 4.17 MB - 0.0 %
    mainChunk 3.02 MB 3.02 MB - 0.0 %

    Note: We do not have exact data for 91643bf7. So we have used data from: 99711d00.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for ac077c84

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Data Stores | 20     | 0      | 0       | 0     | 20    | ✅     |
    | Manage      | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Create      | 38     | 0      | 0       | 2     | 38    | ❗     |
    | Govern      | 36     | 0      | 0       | 0     | 36    | ✅     |
    | Plan        | 47     | 0      | 0       | 0     | 47    | ✅     |
    | Verify      | 8      | 0      | 0       | 0     | 8     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 161    | 0      | 1       | 2     | 162   | ❗     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for bfbfd71b

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Govern | 112    | 0      | 0       | 4     | 112   | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 112    | 0      | 0       | 4     | 112   | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :white_check_mark: test report for ac077c84

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Govern           | 35     | 0      | 0       | 0     | 35    | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 53     | 0      | 4       | 0     | 57    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Savas Vedova added 1 commit

    added 1 commit

    Compare with previous version

  • Savas Vedova added 1 commit

    added 1 commit

    Compare with previous version

  • Savas Vedova added 1 commit

    added 1 commit

    Compare with previous version

  • Savas Vedova added 1 commit

    added 1 commit

    Compare with previous version

  • Savas Vedova added 835 commits

    added 835 commits

    Compare with previous version

  • Savas Vedova changed the description

    changed the description

  • Savas Vedova added 1 commit

    added 1 commit

    Compare with previous version

  • Savas Vedova added 1 commit

    added 1 commit

    Compare with previous version

  • Savas Vedova resolved all threads

    resolved all threads

  • Savas Vedova added 15 commits

    added 15 commits

    Compare with previous version

  • Savas Vedova added 209 commits

    added 209 commits

    Compare with previous version

  • Savas Vedova marked this merge request as ready

    marked this merge request as ready

  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • requested review from @lorenzvanherwaarden

  • Author Maintainer

    @beckalippert can you please do a UX review for this? To simplify your life I created a video which shows the responsiveness. Currently this button does nothing. I'll add the functionality in a separate MR.

    group-by

  • Savas Vedova requested review from @beckalippert

    requested review from @beckalippert

  • mentioned in issue #420055 (closed)

  • removed backend label

  • Becka Lippert approved this merge request

    approved this merge request

  • :wave: @beckalippert, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • A deleted user added backend label

    added backend label

  • Savas Vedova added 1 commit

    added 1 commit

    • 0688e60c - Fix height issues when ff is turned off

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading