Skip to content

Use appropriate `target_details` on approve/create/update events

Sam Figueroa requested to merge sf/refactor/remove-superfluous-member-checks into master

What does this MR do and why?

Refactor to set appropriate target_details on approve/create/update audits.

When auditing the creation or update of a member record we can set more appropriate target_details in many cases. The introduction of this change previously looks like it may have just been copied from the previous implementation where one method had to switch cases for different events and defaulted to a deleted user for all operations.

  • Discovered during Compliance Hackathon, Theme: Audit Events

Screenshots or screen recordings

📝 There is no diff.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Visit any group or project member pages such as http://127.0.0.1:3000/groups/flightjs/-/group_members
  2. Create and/or update a member
  3. Visit audit logs http://127.0.0.1:3000/admin/audit_logs and still see updates for members as usual

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Parts of this description was generated for revision 971ca614 using AI

Edited by Sam Figueroa

Merge request reports