Improve test clean up for migration spec
What does this MR do and why?
This improves clean up for spec/migrations/20230809104753_swap_epic_user_mentions_note_id_to_bigint_for_self_hosts_spec.rb
to fix a master:broken issue - gitlab-org/quality/engineering-productivity/master-broken-incidents#3341 (closed).
This is same as what we have fixed with - !127303 (merged).
We also update spec/migrations/20230810103534_swap_suggestions_note_id_to_bigint_for_self_hosts_spec.rb
as it has the same problem.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.4
added bugtransient groupdatabase typebug labels
assigned to @krasio
added devopsdata stores sectioncore platform labels
added master:broken pipeline:expedite labels
- A deleted user
added database databasereview pending labels
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer database Tianwen Chen (
@tianwenchen
) (UTC+8, 5 hours ahead of@krasio
)Marius Bobin (
@mbobin
) (UTC+3, same timezone as@krasio
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded databaseapproved label and removed databasereview pending label
enabled an automatic merge when the pipeline for b0d655b3 succeeds
requested review from @mbobin
enabled an automatic merge when the pipeline for 3dfe86cd succeeds
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Hello @krasio
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit a662e9e2
picked the changes into the branch
16-3-stable-ee
with commit 98e433d1mentioned in commit 98e433d1
mentioned in merge request !128934 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupdatabase frameworks label and removed groupdatabase [DEPRECATED] label