Skip to content

Removes full stop from Learn More link

What does this MR do and why?

Moves the full stop outside of the Learn More link.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-08-16_at_17.08.20 Screenshot_2023-08-15_at_21.58.00

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Navigate to http://{local-instance}/root/gitlab-shell/-/settings/ci_cd
  2. Scroll down to Token Access and click Expand in front of it
  3. Review the Learn More link in the second Limit access from this project (Deprecated) section
  4. In the file app/assets/javascripts/token_access/components/outbound_token_access.vue, change the line 30 to the following so that the link looks correct:
`CICD|Prevent CI/CD job tokens from this project from being used to access other projects unless the other project is added to the allowlist. It is a security risk to disable this feature, because unauthorized projects might attempt to retrieve an active token and access the API. %{linkStart}Learn more%{linkEnd}.`,

and change lines 258-267 to the following so that Disabling this feature is a permanent change. text that follows the Learn More link is properly aligned

<template #help>
  <gl-sprintf :message="$options.i18n.toggleHelpText">
    <template #link="{ content }">
      <gl-link :href="ciJobTokenHelpPage" class="inline-link" target="_blank">{{ content }}</gl-link>
    </template>
  </gl-sprintf>
  <strong>{{ $options.i18n.disableToggleWarning }} </strong>
</template>
  1. Review the Learn More link in the second Limit access from this project (Deprecated) section after changes

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #414682 (closed)

Edited by Oksana Kohuch

Merge request reports