Draft: Migrate protected branch edit dropdowns to vue
What does this MR do and why?
Migrate protected branch dropdowns to vue
Base Branch: !128575 (merged)
Note to Reviewer:
I am on the community fork and I am unable to stack branches. Please ignore the first two commits as these are from the base branch. This MR needs the changes from the following files to behave properly:
app/assets/javascripts/projects/settings/components/access_dropdown.vue
app/assets/javascripts/deprecated_jquery_dropdown/gl_dropdown.js
app/assets/javascripts/projects/settings/init_access_dropdown.js
These changes are applied on the dropdown components that have shared usages. Given that, we can't merge this yet until the base branch is merged.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
Component instances can be found on Settings > Repository > Protected Branches
Test Project-Level Protected Branch Behavior
- Select a project and go to
Settings > Repository > Protected Branches
- Editing of the protected branches must work as expected.
Additional behavior to validate:
- Search input must be shown when client has EE license, otherwise it must be hidden.
- When client has no EE license,
Allowed to merge dropdown
must be single select.
Test Group-Level Protected Branch Behavior
- Enable the following FF:
group_protected_branches
andallow_protected_branches_for_group
. - Select a group and go to
Settings > Repository > Protected Branches
. - Editing of the protected branches must work as expected.
Additional behavior to validate:
-
Users
should NOT be shown in group-level protected branches, with and without license. - Group-level protected branches should be displayed in Project Repository Settings, however it must not be editable.
- Create a group-level protected branch.
- Open any project under this group and go to the protected branch settings.
- In the edit section (table), the group-level protection must have the fields disabled and there must be a lock icon on the right side.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #284784 (closed)