Skip to content
Snippets Groups Projects

Add sidebar component for standards adherence list page

Merged Jay Montal requested to merge 413718_adherence_report_sidebar into master
All threads resolved!

What does this MR do and why?

What

Adds the sidebar component to the standards adherence list page

Why

Allows users to expand and view fix suggestions for their standards adherence checks

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Sidebar Closed Sidebar Open
image image

How to set up and validate locally

Enable FFs

  1. In the rails console (rails c) enable the following features:
  2. adherence_report_ui (Feature.enable(:adherence_report_ui))
  3. compliance_adherence_report (Feature.enable(:compliance_adherence_report))

Setup Adherences

  1. Visit group settings and enable "Prevent approval by author" from the 'Merge Request Approval' section.
  2. This will create a couple of rows inside the project_compliance_standards_adherence table.

Visit Standard Adherence page

  1. Visit a group, under Secure (new UI) or Security & Compliance (old UI) > Compliance center
  2. Click View details to expand the sidebar component

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay Montal

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @lorenzvanherwaarden

  • Jay Montal added 1 commit

    added 1 commit

    • 534ae90a - Updates based on initial feedback

    Compare with previous version

  • Jay Montal added 1 commit

    added 1 commit

    • 777a0ed4 - Updates based on initial feedback

    Compare with previous version

  • Jay Montal removed review request for @lorenzvanherwaarden

    removed review request for @lorenzvanherwaarden

  • 🤖 GitLab Bot 🤖 changed milestone to %16.4

    changed milestone to %16.4

  • Jay Montal added 1 commit

    added 1 commit

    • 00363811 - Updates based on initial feedback

    Compare with previous version

  • requested review from @lorenzvanherwaarden

  • Jay Montal added 1 commit

    added 1 commit

    • 5131f9ab - Updates based on initial feedback

    Compare with previous version

  • Jay Montal requested review from @cam.x

    requested review from @cam.x

  • Author Developer

    Hi @eread - could you please do the Technical Writing review for this please?

    There's a few threads above that aren't resolved so I will also mention you in those for clarity, thanks!

  • Jay Montal requested review from @eread

    requested review from @eread

  • Evan Read
  • added UI text label

  • Evan Read removed review request for @eread

    removed review request for @eread

  • Lorenz van Herwaarden approved this merge request

    approved this merge request

  • :wave: @lorenzvanherwaarden, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • removed review request for @lorenzvanherwaarden

  • Camellia X Yang requested review from @lvanc

    requested review from @lvanc

  • Camellia X Yang removed review request for @cam.x

    removed review request for @cam.x

  • Jay Montal added 1 commit

    added 1 commit

    • 271f5aac - Updates based on docs feedback and final initial feedback

    Compare with previous version

  • Jay Montal added 1 commit

    added 1 commit

    • fe0ae339 - Updates based on docs feedback and final initial feedback

    Compare with previous version

    • Resolved by Jay Montal

      @jmontal Overall it works as expected, just noticed a few things.

      suggestion(non-blocking): after reviewing the drawer, it looks like the large heading in the drawer title is causing the close button to appear lower since everything is middle aligning inside the title container.

      What do you think about either...

      1. moving status (e.g. "Fail etestr") outside of the title container like in the storybook example
      2. Making the text title smaller / removing the h2
      3. top aligning the content in the title
      Current (middle aligned) Expected (Top aligned)
      Screenshot_2023-09-11_at_11.01.52_AM Screenshot_2023-09-11_at_11.01.01_AM

      @gitlab-com/gitlab-ux/ux-foundations any thoughts on this :point_up:

  • Jay Montal added 4100 commits

    added 4100 commits

    • fe0ae339...3dc7cc59 - 4094 commits from branch master
    • 0392d94a - Create list for standards adherence report
    • 39d3dbbd - Use GraphQL endpoint
    • 395bca5b - Updates based on maintainer feedback
    • d80a744d - Add standards adherence report sidebar
    • 2b9e67c9 - Updates based on initial feedback
    • 335863a9 - Updates based on docs feedback and final initial feedback

    Compare with previous version

  • Jay Montal requested review from @iamphill

    requested review from @iamphill

  • Phil Hughes
  • Phil Hughes
  • Phil Hughes
  • Phil Hughes removed review request for @iamphill

    removed review request for @iamphill

  • Jay Montal added 7 commits

    added 7 commits

    • e7b8f283 - Create list for standards adherence report
    • b9694f3d - Use GraphQL endpoint
    • c1d4ac27 - Updates based on maintainer feedback
    • 10307088 - Add standards adherence report sidebar
    • 5131f9ab - Updates based on initial feedback
    • fe0ae339 - Updates based on docs feedback and final initial feedback
    • 7c9a0b8b - Merge branch '413718_adherence_report_sidebar' of gitlab.com:gitlab-org/gitlab...

    Compare with previous version

  • Jay Montal requested review from @iamphill

    requested review from @iamphill

  • mentioned in issue #419961 (closed)

  • Jay Montal marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Phil Hughes
  • Phil Hughes
  • Phil Hughes removed review request for @iamphill

    removed review request for @iamphill

  • Jay Montal
  • Jay Montal added 1 commit

    added 1 commit

    • 7f160a70 - Merge branch '413718_adherence_report_sidebar' of gitlab.com:gitlab-org/gitlab...

    Compare with previous version

  • mentioned in issue #413718 (closed)

  • mentioned in issue #421327 (closed)

  • Libor Vanc approved this merge request

    approved this merge request

  • Libor Vanc removed review request for @lvanc

    removed review request for @lvanc

  • Jay Montal added 1 commit

    added 1 commit

    • a060b2be - Merge branch '413718_adherence_report_sidebar' of gitlab.com:gitlab-org/gitlab...

    Compare with previous version

  • Jay Montal added 1 commit

    added 1 commit

    • 2d89222b - Merge branch '413718_adherence_report_sidebar' of gitlab.com:gitlab-org/gitlab...

    Compare with previous version

  • Jay Montal requested review from @iamphill

    requested review from @iamphill

  • Libor Vanc mentioned in merge request !131280 (merged)

    mentioned in merge request !131280 (merged)

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes resolved all threads

    resolved all threads

  • Phil Hughes enabled an automatic merge when the pipeline for 6351e6fe succeeds

    enabled an automatic merge when the pipeline for 6351e6fe succeeds

  • merged

  • Phil Hughes mentioned in commit 087d10da

    mentioned in commit 087d10da

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading