Skip to content

Remove feat flags: delete unconfirmed user feature

Jessie Young requested to merge jy-delete-unconfirmed-users-setting-feature-flags into master

What does this MR do and why?

  • This feature was added behind 2 feature flags: one for backend, one for frontend.
  • The backend feature flag has been turned on for gitlab.com for over a month: #414252 (comment 1450424257)
  • The frontend one has been turned on for gitlab.com for over a day: #416339 (comment 1502277864)
  • We are confident that this code works as expected so we can remove the feature flags.
  • If we want to turn off the feature, we can do that by setting the application setting delete_unconfirmed_users to false
  • #414252 (closed)
  • #416339 (closed)

How to set up and validate locally

This enables an existing feature but removes feature flag checks. See validation instructions in the MRs where the logic was added initially:

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jessie Young

Merge request reports