Skip to content

Fix flaky test on CI

Kassio Borges requested to merge kassio/fix-flaky-test into master

What does this MR do and why?

Fix flaky test on CI

When extracting some pages-related methods from Project to Gitlab::Pages::UrlBuilder, the Project#pages_subdomain was removed, therefore the shows the DNS ALIAS record spec on spec/features/projects/pages/user_adds_domain_spec.rb had to be refactored.

This introduced a bug, where the namespace used in the test was hardcoded.

To fix this, I'm reverting the test to use dynamic values based on the variables built for the test.

Related to: gitlab-org/quality/engineering-productivity/master-broken-incidents#3214 (closed)

Changelog: fixed

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports