Exclude archived projects from blob search
What does this MR do and why?
Exclude archived projects from blob search
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Make sure advanced search is enabled.
- Add a commit with some specific message like
foobar
on 2 projects - Archive one of the projects from project settings
- Now search for
foobar
. You should see the results from both projects underprojects
- Now enable the feature-flag
search_blob_hide_archived_projects
- Now search again, you should see the results from only non-archived project
- Repeat the same steps and test for group search as well.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #414901 (closed)
Merge request reports
Activity
changed milestone to %16.3
assigned to @sdungarwal
- A deleted user
added backend feature flag labels
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Marcos Rocha (
@mc_rocha
) (UTC-4, 9.5 hours behind@sdungarwal
)Marc Shaw (
@marc_shaw
) (UTC+2, 3.5 hours behind@sdungarwal
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b6b184ad
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 43f5349dexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 36 | 0 | 0 | 0 | 36 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Create | 46 | 0 | 1 | 2 | 47 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 13 | 0 | 1 | 1 | 14 | ❗ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 180 | 0 | 4 | 3 | 184 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 4016ddf6expand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
changed milestone to %16.4
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e832ed18
added 1 commit
- e094f98a - Fix spec by using Gitlab::Search::FoundBlob model
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@60d59291
mentioned in commit f0a8dc43
added 1 commit
- a6735ec2 - Add eql? method in found_blob to fix the failing specs
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@68540c98
added 399 commits
-
a6735ec2...71c76864 - 397 commits from branch
master
- 95141e59 - Merge branch 'master' into 414901-excluded-archived-from-blob-search
- 962b4c1d - Fix rubocop failures after master merge
-
a6735ec2...71c76864 - 397 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7dcffa7d
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@cb084a85
mentioned in commit d30e58d4
added 280 commits
-
4b226a3b...729abcb2 - 276 commits from branch
master
- d30e58d4 - Exclude archived projects from blob search
- c6fc0250 - Add eql? method in found_blob to fix the failing specs
- a360c33c - Fix rubocop failures after master merge
- 8330e360 - Fix pipeline failures
Toggle commit list-
4b226a3b...729abcb2 - 276 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@80fe2f07
- Resolved by Dmitry Gruzd
@a_luna can you do an initial review and assign to
@terrichu
for maintainer review, this MR will be merged after !127365 (merged) hits production and so you can ignore the 3 files mentioned below as they are already reviewed in the older MR:ee/elastic/docs/20230724185512_backfill_archived_field_in_blob.yml
ee/elastic/migrate/20230724185512_backfill_archived_field_in_blob.rb
ee/spec/elastic/migrate/20230724185512_backfill_archived_field_in_blob_spec.rb
Edited by Siddharth Dungarwal
requested review from @a_luna
- Resolved by Siddharth Dungarwal
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2f39e091
- Resolved by Siddharth Dungarwal
- Resolved by Siddharth Dungarwal
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@5ef8c0ce
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@aa0b19e0
- Resolved by Siddharth Dungarwal
removed review request for @a_luna
mentioned in epic &10957 (closed)
added 7 commits
- f0a8dc43 - Exclude archived projects from blob search
- a6735ec2 - Add eql? method in found_blob to fix the failing specs
- 95141e59 - Merge branch 'master' into 414901-excluded-archived-from-blob-search
- 962b4c1d - Fix rubocop failures after master merge
- 4b226a3b - Fix pipeline failures
- 4251c73c - Add spec for eql method
- b970be01 - Merge branch '414901-excluded-archived-from-blob-search' of...
Toggle commit listrequested review from @a_luna
- Resolved by Siddharth Dungarwal
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@93b31af0
removed review request for @a_luna
@a_luna
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links: