Delete importer and prometheus metrics importer
What does this MR do and why?
Delete importer and prometheus metrics importer
Delete related usages of class
Delete related specs
Screenshots or screen recordings
NA
How to set up and validate locally
- Pipeline should be
- The deleted classes were not used anywhere except specs, so there is nothing major to verify.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #397139 (closed)
Merge request reports
Activity
changed milestone to %16.3
assigned to @rkadam3
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @rkadam3 Some end-to-end (E2E) tests have been selected based on the stage label on this MR.Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing before this MR is merged. (The E2E test pipeline is computationally intensive and we cannot afford running it automatically for all pushes/rebases. Therefore, this job must be triggered manually after significant changes at least once.)If you would like to run all E2E tests, please apply the pipeline:run-all-e2e label and trigger a new pipeline. This will run all tests in
e2e:package-and-test
pipeline.The E2E test jobs are allowed to fail due to flakiness. For the list of known failures please refer to the latest pipeline triage issue.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
- Resolved by Peter Leitzen
@splattael - Mind taking direct maintainer review on this one, please?
requested review from @splattael
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 05762e1fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 47 | 0 | 0 | 6 | 47 | ❗ | | Data Stores | 20 | 0 | 0 | 8 | 20 | ❗ | | Create | 38 | 0 | 0 | 13 | 38 | ❗ | | Verify | 8 | 0 | 0 | 2 | 8 | ❗ | | Govern | 34 | 0 | 0 | 9 | 34 | ❗ | | Manage | 12 | 0 | 1 | 12 | 13 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 163 | 0 | 1 | 50 | 164 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@splattael
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for d209ffb7 succeeds
mentioned in commit ffef2d30
added workflowstaging-canary label and removed workflowblocked label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/monitor/respond#264 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/monitor/respond#266 (closed)