Skip to content

No-op label column add DB migration

charlie ablett requested to merge 421145-cablett-no-op-labels-migration into master

What does this MR do and why?

No-ops a migration introduced in !127683 (merged) that caused a deployment block incident gitlab-com/gl-infra/production#16134 (closed)

See the reasoning for the error in #421145 (comment 1502178641)

we run migrations on Canary, then wait a few hours before rotating pods for Main stage.

So Rails pods on main stage will have cached columns lists, which will not match the list returned by attributes. attributes gets the list by making a database query.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #421145 (closed)

Edited by charlie ablett

Merge request reports